Strange issue with albumdisambig

pandatroubles · August 8, 2021, 7:00pm

Hi! Me again.

After #3852 was fixed, I am having a strange result with albumdisambig.

github.com/beetbox/beets

%ifdef does not work on flexattr fields with int or float

opened 09:13PM - 08 Feb 21 UTC

closed 03:12PM - 17 Jun 21 UTC

wazabees

bug

### Problem If I try `beet ls -a -f '$albumartist - (%if{$original_year,$origin…al_year,$year}) - $album%ifdef{albumdisambig, (%title{$albumdisambig}),}%ifdef{albumrating, ($albumrating),}' year:2021` then beets will return the album rating for the albums that has the field defined. For albums without the rating, `$albumrating` is returned. Example: ``` Artist1 - (2021) - Albumname1 (2.0) Artist2 - (2021) - Albumname2 ($albumrating) ``` Further information on the forum: https://discourse.beets.io/t/album-rating-as-a-flexible-attribute-in-5-increments/1687/3 Comment from adrian: _reading over the implementation of %ifdef, I can see now how it would be confused about types with a default value. That is, int or float fields will produce a '0' string for unset values through the formatter, which gets interpreted as non-missing. We clearly need better logic for this._ ### Setup * OS: Arch Linux * beets version 1.5.0 * Python version 3.9.1 * plugins: edit, extrafiles, fetchart, importadded, importfeeds, info, inline, lastimport, mbcollection, mbsync, mpdstats, mpdupdate, originquery, scrub, smartplaylist, types, zero

A few examples below:

beet ls -f '%asciify{$albumartist}/%if{$original_year,$original_year,$year} - $album%ifdef{albumdisambig, ($albumdisambig),}%ifdef{u_type, [$u_type],}/%right{$disc,1}-$track - $title' album:"The Gereg" track:1

Result: The HU/2019 - The Gereg (deluxe edition)/1-01 - The Gereg

The above command gives me the expected output. I want “deluxe edition” capitalized, so I’ll change the command to this:

beet ls -f '%asciify{$albumartist}/%if{$original_year,$original_year,$year} - $album%ifdef{albumdisambig, (%title{$albumdisambig}),}%ifdef{u_type, [$u_type],}/%right{$disc,1}-$track - $title' album:"The Gereg" track:1

Again, I get the expected result, which is The HU/2019 - The Gereg (Deluxe Edition)/1-01 - The Gereg.

If I try an album that has u_type set, but empty albumdisambig, I get extra (), which is not expected.

beet ls -f '%asciify{$albumartist}/%if{$original_year,$original_year,$year} - $album%ifdef{albumdisambig, (%title{$albumdisambig}),}%ifdef{u_type, [$u_type],}/%right{$disc,1}-$track - $title' album:Nightmother track:1

Result: Wormlight/2021 - Nightmother () [Bandcamp]/1-01 - Nightmother

And if I try an album with empty u_type and empty albumdisambig, I see the same issue with extra () from albumdisambig, but there is no extra [] from u_type.

beet ls -f '%asciify{$albumartist}/%if{$original_year,$original_year,$year} - $album%ifdef{albumdisambig, (%title{$albumdisambig}),}%ifdef{u_type, [$u_type],}/%right{$disc,1}-$track - $title' album:Singularity track:1

Result: Stortregn/2016 - Singularity ()/1-01 - Enlighten Salvation

This leads be to believe the issue is with albumdisambig, but I am not sure why.

My installation is on Arch Linux:

╰─❯ beet --version
beets version 1.5.0
Python version 3.9.6
plugins: edit, fetchart, importadded, importfeeds, info, inline, lastimport, mbcollection, mbsync, mpdstats, mpdupdate, originquery, playlist, scrub, smartplaylist, types, zero

Thanks for reading!

Topic		Replies	Views
Album rating as a flexible attribute in .5 increments? Help	6	453	February 8, 2021
Multiple values for a custom field? (tagging/labeling) Help	1	396	January 5, 2020
Regex query across all fields Help	2	493	September 29, 2018
Using custom fields as aunique keys Help	2	463	April 16, 2020
Query items without certain field Help	3	2138	April 11, 2024

Strange issue with albumdisambig

Related Topics